96fc21ac7d
Four things the ADS-B mode was missing, and one it was actively getting
wrong.
The band plan lists 1090 MHz because that is where ADS-B is, so choosing
it from the band plan is the obvious thing to do -- and it records the
bursts as clicks in a WAV file and decodes nothing, silently. Both the
scanner and the menus now say so, before the sweep starts, and name the
mode that does decode it. It is not refused: looking at the raw spectrum
is a fair thing to want.
Menu 5, Aircraft (ADS-B), is the whole mode without a command line. Every
option on one screen with a line saying what it does, ?N for the long
version and the flag it corresponds to, l to listen, m to draw a map from
any log, s to keep the options. The listening and the drawing moved into
bandsaunter/aircraft.py so the menus and the command line run the same
code.
While it listens the screen is a live board: one line per aircraft in the
order first heard, the counter climbing as frames arrive, height coloured
low warm to high cold with an arrow for climb or descent, the age of the
last report going green to red, and the line removed once nothing has been
heard for --hold seconds, everything below moving up. The registers are
asked while it runs, so registration, type, operator and route fill
themselves in as the answers arrive.
--speed-unit knots|mph|kph changes the heading of that board, the speed
beside every aircraft on the map and the speeds in the report, and moves
the distances with it so that one picture never carries two different
miles. The log stays in knots, which is what the aircraft broadcast.
And there is a real map under the flight paths: {z}/{x}/{y} tiles fetched
once, cached in ~/.cache/bandsaunter/tiles, reprojected from Web Mercator
pixel by pixel, inverted and dimmed so the aircraft stay the brightest
thing on the picture. The PNGs are decoded here -- zlib and the five row
filters from the specification, checked byte for byte against Pillow on
real tiles -- so nothing new is depended on. Tiles are cached and never
re-fetched, every request says who is asking, and the attribution is drawn
onto the picture, because a GIF travels without its readme.
conftest now fails any test that reaches for a tile server or a register.
It caught four of these on the way in.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016PsWPTweCT6pwxKngvVxcg
96 lines
3.5 KiB
Python
96 lines
3.5 KiB
Python
"""Fixtures every test gets.
|
|
|
|
All three are about not touching the machine the tests run on, or anyone
|
|
else's.
|
|
|
|
The cache: a lookup writes to ``~/.cache`` by default, and a test run that
|
|
touches the real one leaves entries behind and reads back entries an earlier
|
|
version wrote. Redirecting it per test makes each run start from nothing.
|
|
|
|
The settings: locking a frequency out writes it into ``config.yaml``, and a
|
|
test that reached the real one would silently change what the next real scan
|
|
does. The constant is replaced in every module that holds a copy, so that
|
|
forgetting to pass a directory somewhere cannot end in someone's own settings.
|
|
|
|
The network: a licence lookup goes to a public database and returns a real
|
|
person's name and address. No test has any business doing that.
|
|
"""
|
|
import pytest
|
|
|
|
import bandsaunter.browse
|
|
import bandsaunter.callsign
|
|
import bandsaunter.cli
|
|
import bandsaunter.config
|
|
import bandsaunter.tui
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def isolated_cache(tmp_path_factory, monkeypatch):
|
|
monkeypatch.setenv("XDG_CACHE_HOME",
|
|
str(tmp_path_factory.mktemp("cache")))
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def no_licence_lookups(monkeypatch):
|
|
"""No test may contact the licence database.
|
|
|
|
One did, silently, and passed -- it was only visible because the
|
|
assertion it failed printed a real operator's address. A test that wants
|
|
answers stubs this itself; anything else fails loudly rather than going
|
|
to the network and being slow, flaky and rude about it.
|
|
"""
|
|
def refuse(self, url, call):
|
|
raise AssertionError(f"a test tried to look up {call} for real")
|
|
|
|
monkeypatch.setattr(bandsaunter.callsign.CallsignBook, "_request", refuse)
|
|
|
|
|
|
class NoNetwork(BaseException):
|
|
"""Raised when a test reaches for the network.
|
|
|
|
Deliberately not an ``Exception``: the code that fetches map tiles and
|
|
looks aircraft up treats any ordinary failure as "no map today" and
|
|
carries on, which would turn this guard into a silent pass.
|
|
"""
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def no_aircraft_lookups(monkeypatch):
|
|
"""Nor may a test ask a register who an aircraft is."""
|
|
import bandsaunter.flights
|
|
|
|
def refuse(self, url):
|
|
raise NoNetwork(f"a test tried to fetch {url} for real")
|
|
|
|
monkeypatch.setattr(bandsaunter.flights.FlightBook, "_request", refuse)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def no_map_tiles(monkeypatch):
|
|
"""Nor fetch map tiles from somebody's tile server.
|
|
|
|
A test that wants a map builds its own tiles and passes them in; one
|
|
that forgets fails here rather than drawing an evening's worth of
|
|
requests at a volunteer-funded service.
|
|
"""
|
|
import bandsaunter.basemap
|
|
|
|
def refuse(request, timeout=None):
|
|
where = getattr(request, "full_url", request)
|
|
raise NoNetwork(f"a test tried to fetch {where} for real")
|
|
|
|
monkeypatch.setattr(bandsaunter.basemap.urllib.request, "urlopen", refuse)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def isolated_settings(tmp_path_factory, monkeypatch):
|
|
where = tmp_path_factory.mktemp("config")
|
|
for module in (bandsaunter.config, bandsaunter.browse, bandsaunter.cli,
|
|
bandsaunter.tui):
|
|
if hasattr(module, "DEFAULT_CONFIG_DIR"):
|
|
monkeypatch.setattr(module, "DEFAULT_CONFIG_DIR", where)
|
|
if hasattr(module, "DEFAULT_CONFIG_PATH"):
|
|
monkeypatch.setattr(module, "DEFAULT_CONFIG_PATH",
|
|
where / "config.yaml")
|
|
monkeypatch.setenv("BANDSAUNTER_CONFIG_DIR", str(where))
|
|
return where
|