Redraw cleanly when the window is resized
Resizing the terminal during a scan left the screen full of wreckage: box corners in the middle of a line, borders twice the width of the window, a "receiver" header printed eight times down the left edge. Four separate defects, which is why it looked so bad. Live rendering works by moving the cursor back over the frame it drew last time and overwriting it. That is only correct while the frame is still where it was put, and none of these programs noticed when it was not. 1. Nothing detected a resize. Both the scan display and saunterbrowse now compare the console size on every frame and clear the screen when it changes -- polled rather than handled as a signal, because the display is redrawn several times a second anyway and a signal handler that runs in the middle of a write has to be right about far more than this does. Anything printed before the scan started scrolls away at that point, which the manual now says. 2. The layout's model of its own height was wrong, in two places that cancelled. The sweep panel was counted as one line shorter than it is, the hit list as one line taller. The sum came out right whenever both were drawn and wrong on a terminal too short for the hit list -- where the frame then overflowed by one line on every refresh and the top of it marched down the screen. That is what the eight headers were. Each panel height is a named constant now, and a test checks every one of them against what is actually rendered. 3. Lines inside the panels could wrap. A band name, a long status line or a decoded message made a panel a row taller than the arithmetic allowed for, with the same result. Every one is drawn on a single line and ellipsised now. The receiver panel drops its optional parts instead, keeping the tuner and the flags: "SIMULATED" disappearing off the end of a narrow line is how somebody comes to believe they are listening to the air. 4. saunterbrowse's full-screen views did not fill the screen. Nothing erases the alternate screen between frames -- the cursor is sent home and the new frame written over the old one -- so pressing t or ? on a tall window left most of the recording list visible underneath. Both are wrapped in a layout now, which fills the terminal exactly. The layout also gives up the receiver panel on a very short terminal, which it previously had no way to do: on eight rows the smallest frame it could describe was nine lines. Testing this by rendering to a wide Console and reading the text back cannot work -- whether the cursor lands where it should is a property of the terminal, not of the renderable. So tests/terminal.py runs the program in a pty, resizes the window underneath it the way a window manager does, and feeds what it writes to a terminal emulator whose screen is then read. Every fix above has a test that fails without it, checked by reverting each one in turn. pyte is a dev dependency and those tests skip without it; the arithmetic ones need nothing. Also: t now opens the reader for a capture that carries decoded data rather than speech, because the decoded panel already told the reader to press it. 869 -> 949 tests.
This commit is contained in:
parent
68b05a031c
commit
d6ae6d0c22
12 changed files with 625 additions and 46 deletions
|
|
@ -273,7 +273,19 @@ def test_the_reader_refuses_when_there_is_nothing_to_read(library):
|
|||
b.index = [i for i, c in enumerate(b.view) if c.mode == "fsk"][0]
|
||||
b.handle("t")
|
||||
assert not b.reading
|
||||
assert "no transcript" in b.message
|
||||
assert "nothing to read" in b.message
|
||||
|
||||
|
||||
def test_the_reader_opens_on_a_decoded_capture_too(tmp_path):
|
||||
"""The decoded panel says "press t to read it all", so t has to work."""
|
||||
make_capture(tmp_path, 929.6125, "2026-08-22_11_00_00", "fsk", 4.0,
|
||||
meta={"category": "digital", "data_protocol": "POCSAG 1200",
|
||||
"data_messages": ["[1234568D] ENGINE 4 RESPOND"]})
|
||||
b = browser(tmp_path)
|
||||
assert not b.current.transcript and b.current.decoded
|
||||
b.handle("t")
|
||||
assert b.reading, b.message
|
||||
assert "ENGINE 4 RESPOND" in frame(b)
|
||||
|
||||
|
||||
# -- the frame ---------------------------------------------------------------
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue